Skip to content

Fix shellFor components argument #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2021
Merged

Fix shellFor components argument #1079

merged 2 commits into from
Apr 8, 2021

Conversation

hamishmack
Copy link
Collaborator

No description provided.

@michaelpj
Copy link
Collaborator

So... the problem here is that the contents of component.depends is a mix of packages and components? Could we instead make it so that it was always components? i.e. so instead of putting the package (as we do now) we would actually put the main library component?

@hamishmack
Copy link
Collaborator Author

I have added #1679. Unfortunately fixing that will require updating all the materialized files, so I think we should wait until we have a more compelling reason to update them.

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 7, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 8, 2021

@rvl
Copy link
Contributor

rvl commented Apr 8, 2021

Nice idea @hamishmack.

@hamishmack
Copy link
Collaborator Author

bors try

iohk-bors bot added a commit that referenced this pull request Apr 8, 2021
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Apr 8, 2021

@hamishmack hamishmack merged commit 618ff60 into master Apr 8, 2021
@iohk-bors iohk-bors bot deleted the hkm/shell-components branch April 8, 2021 03:33
booniepepper pushed a commit to booniepepper/haskell.nix that referenced this pull request Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants